Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDV (using BSync v0.2.0) related question #127

Closed
JanghyunJK opened this issue Jun 28, 2021 · 7 comments · Fixed by #129
Closed

EDV (using BSync v0.2.0) related question #127

JanghyunJK opened this issue Jun 28, 2021 · 7 comments · Fixed by #129
Assignees
Labels
bug Something isn't working

Comments

@JanghyunJK
Copy link

I was testing EDV workflow lately and found something that was missing in tag version v0.2.0 but which was available in the current (as of today) develop branch. Summary below.

  • EDV plan is to use BuildingSync-gem v0.2.0 (for now) for creating EP/OS models

  • but when I run below on EDV's side,
    translator = BuildingSync::Translator.new(xml_file_path, out_path, epw_file_path, standard, false)

  • I was getting the following error
    Error occurred while processing C:/Users/JKIM4/Documents/GitHub/edv-experiment-1/workflow_results/Add_Measured_Data_Files/Panther_office_Karla.xml with message: uninitialized constant BuildingSync::Generator Did you mean? Enumerator

  • was tracking down why it wasn't accepting BuildingSync::Generator and found out translator.rb wasn't including require 'buildingsync/generator' in v0.2.0 while it was there in develop branch as shown here

  • so was wondering,

    • if this difference was intended for v0.2.0
    • or if require 'buildingsync/generator' could also be added in v0.2.0

Let me know if I'm just at the wrong place for this issue or if you have any questions/comments/suggestions. Thanks!!

@JanghyunJK
Copy link
Author

tagging @lainsworth8801

@JanghyunJK JanghyunJK added the bug Something isn't working label Jul 1, 2021
@nllong nllong assigned aviveiros11 and unassigned nllong Jul 2, 2021
@nllong
Copy link
Member

nllong commented Jul 7, 2021

@aviveiros11 -- are you able to tackle this issue?

@aviveiros11
Copy link

@nllong yes! Just have to clear some things off of my plate first. Will investigate when I can.

@nllong
Copy link
Member

nllong commented Jul 7, 2021

sounds good. let me know what you find.

@JanghyunJK
Copy link
Author

@aviveiros11 any updates on this yet?

@aviveiros11
Copy link

@aviveiros11 any updates on this yet?

Haven't had time but will move this up on my priority list of to-dos!

@JanghyunJK
Copy link
Author

@aviveiros11 any updates on this yet?

Haven't had time but will move this up on my priority list of to-dos!

got it, thanks Rock Lee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants