Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep version 0.2.1 #129

Merged
merged 4 commits into from
Sep 10, 2021
Merged

prep version 0.2.1 #129

merged 4 commits into from
Sep 10, 2021

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Aug 26, 2021

Fixes #127
Fixes #130

@kflemin kflemin requested a review from nllong August 26, 2021 18:04
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤑

def purge_skipped_from_workflow(workflow)
non_skipped = []
if !workflow.nil? && !workflow['steps'].nil? && workflow.key?('steps')
workflow['steps'].each do |step|
if !step.nil? && step.key?('arguments') && !step['arguments'].nil?
if step['arguments'].key?('__SKIP__') && step['arguments']['__SKIP__'] == false
if !step.nil? && step.key?('arguments')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find and fix!

@kflemin kflemin merged commit c94cb54 into develop Sep 10, 2021
@kflemin kflemin deleted the prep_v0.2.1 branch September 10, 2021 17:21
@JanghyunJK
Copy link

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update purge measures method EDV (using BSync v0.2.0) related question
3 participants