Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map common floor-area type #132

Merged
merged 2 commits into from
Sep 11, 2021
Merged

map common floor-area type #132

merged 2 commits into from
Sep 11, 2021

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Sep 10, 2021

Fixes #131

@kflemin kflemin requested a review from nllong September 10, 2021 18:56
nllong
nllong approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like if there is both a Conditioned floor area and a Common floor area in the same block of BuildingSync, then it will only grab the last one, correct?

lib/buildingsync/model_articulation/spatial_element.rb Outdated
@@ -89,7 +89,7 @@ def read_floor_areas(parent_total_floor_area)
@conditioned_floor_area_heated_cooled = OpenStudio.convert(validate_positive_number_excluding_zero('@heated_and_cooled_floor_area', floor_area), 'ft^2', 'm^2').get
elsif floor_area_type == 'Footprint'
@footprint_floor_area = OpenStudio.convert(validate_positive_number_excluding_zero('@footprint_floor_area', floor_area), 'ft^2', 'm^2').get
elsif floor_area_type == 'Conditioned'
elsif floor_area_type == 'Conditioned' || floor_area_type == 'Common'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@kflemin kflemin merged commit f5c5fd0 into develop Sep 11, 2021
@kflemin kflemin deleted the common-floor-area branch September 11, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

floor area type processing does not handle some of the buildingsync enums
2 participants
@kflemin @nllong