Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 138/rewrite and test sets occupancy bldg system types #150

Merged

Conversation

haneslinger
Copy link
Contributor

@haneslinger
Copy link
Contributor Author

haneslinger commented Feb 10, 2024

the tests are failing (at least in part) because properly handling unit conversion causes this test to be a Large building instead of a medium one, and thus error different.

Both the error that was, "undefined method `add_internal_loads' for nil:NilClass", and the error that now is, "Did not find a", are a bit wanting. I'm going to see what can be done

@haneslinger
Copy link
Contributor Author

okay, so the full line its failing on is here

the full error is "ERROR: Did not find a class called 'CBES T24 2008_LargeOffice' to create in" and then a VERY long list. You can see the full list here. Sure enough, 'CBES T24 2008_LargeOffice', but "2008_MediumOffice" is .

We can either remove the test or change the floor area to a true medium office. @ThibaultMarzullo?

@haneslinger
Copy link
Contributor Author

@ThibaultMarzullo I'm thinking we move this test to the fail pile, sound good?

@haneslinger haneslinger force-pushed the FIX-138/Rewrite-and-test-sets_occupancy_bldg_system_types branch from 2670bb8 to 153e4b2 Compare February 14, 2024 21:06
@haneslinger haneslinger merged commit ec66b2c into develop Feb 14, 2024
8 checks passed
@haneslinger haneslinger deleted the FIX-138/Rewrite-and-test-sets_occupancy_bldg_system_types branch February 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants