Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#211 Splash added #233

Closed
wants to merge 4 commits into from
Closed

#211 Splash added #233

wants to merge 4 commits into from

Conversation

codingblazer
Copy link
Contributor

No description provided.

@codingblazer
Copy link
Contributor Author

codingblazer commented Nov 26, 2016

Hey @croozeus @opticod , There is some problem with armeabi-v7a installation in Travis CI due to which build is failing as happened in #230 PR of free4murad . I have tried some solutions from my side which didn't worked and other will require some modification in travis.yml file by you. I have attached some links for these which you may find useful.Thanks.

Solution 1
Follow up of above
Related Question for above on SO
Solution 2
Solution for similar issue (m2k repo installation problem)

@m-murad
Copy link
Contributor

m-murad commented Nov 26, 2016

@croozeus @opticod
Yes there is some problem with Travis CI.
My PR is also not able to build properly.

@opticod
Copy link
Collaborator

opticod commented Nov 27, 2016

@codingblazer @free4murad , yaa I too observed it yesterday. I also tried restarting the build but it too failed. Thanks for your solutions. Let me fix it. You all can also help. If it still doesn't work, then we can move to Circle-CI, its more reliable and faster. I too explored it during my GSoC period but it requires some admin permissions to set up @croozeus.

@m-murad
Copy link
Contributor

m-murad commented Nov 27, 2016

@opticod
should i make a PR to migrate the project from Travis to Circle-CI.

@opticod
Copy link
Collaborator

opticod commented Nov 29, 2016

@free4murad , First we should try solving travis. If it doesn't work, then you can continue.

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingblazer Can't you add the splash without adding the new splashmain.jpeg? Try to exploit the existing image first_run_bg.jpg

@croozeus
Copy link
Member

croozeus commented Nov 29, 2016

Regarding problem with Travis-CI - we need to fix this. I would really not want to move to Circle-CI as Travis-CI is more open source friendly. @opticod can you look into this at priority. Meanwhile, please do not merge any changes that fail the CI checks.

@opticod
Copy link
Collaborator

opticod commented Nov 29, 2016

Ok sure @croozeus sir, trying to fix travis.

@croozeus
Copy link
Member

Thanks @opticod If you want you can create an issue for this so that others can discuss, give their suggestions on this.

@codingblazer
Copy link
Contributor Author

codingblazer commented Nov 29, 2016

@opticod I also considered reusing the first_run_bg.jpg but the problem is -
first_run_bg.jpg doesn't have "BuildmLearn Toolkit" Text in the image like in mainsplash.jpg and i can't add this text to first_run_bg.jpg using android theme ( I am implementing theme based splash as discussed). If I have to add text to first_run_bg , I have to create xml to add this text which means purpose of using theme based splash will be ruined as discussed in that article. I even tried creating my own drawable with first_run_bg as bitmap item but no help there. Please tell if you have any solution to this.

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a new commit following your commit. There I have created a very small png file of the text and added it using layers. It will not void the ideas described in that article.

@opticod
Copy link
Collaborator

opticod commented Dec 4, 2016

Merged via d7f0fbd and fa3dc90

@opticod opticod closed this Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants