Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vendor folder in repo - use dep instead #47

Open
mukeshmk opened this issue Oct 10, 2018 · 6 comments
Open

remove vendor folder in repo - use dep instead #47

mukeshmk opened this issue Oct 10, 2018 · 6 comments

Comments

@mukeshmk
Copy link

Currently, the repo contains the vendor folder. Which need not be tracked by version control, as Gopkg.toml and Gopkg.lock files are used to track your dependencies. So please remove the vendor folder.

The vendor folder will be created with the same version of dependencies as specified in Gopkg.toml, upon running dep init.

@mukeshmk
Copy link
Author

fixed it with the PR #48.

@0xch4z
Copy link
Contributor

0xch4z commented Oct 13, 2018

Just curious, why would you use dep over official go 1.11 modules? (see: golang/dep#1959 (comment))

@mukeshmk
Copy link
Author

I agree this info (in the below-mentioned link) is old, but it is still valid:
This is the major difference as mentioned in the PR aka Doc-FAQ.
There is a subtle difference in what you are trying to achieve, that would be the key difference.

golang/dep#376

@0xch4z
Copy link
Contributor

0xch4z commented Oct 13, 2018

Right, but I'm not comparing dep to go get. I'm comparing it to go mod, which versions packages in a go.mod file and creates a go.sum file to summarize dependency installation for reproducible builds.

@mukeshmk
Copy link
Author

Are we using go mod here? 🤔

@0xch4z
Copy link
Contributor

0xch4z commented Oct 13, 2018

No

Repository owner deleted a comment from floatingdev Jan 31, 2024
Repository owner deleted a comment from 19890843006 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mukeshmk @0xch4z and others