Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to service and deployment types #19

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add labels to service and deployment types #19

merged 1 commit into from
Jun 7, 2024

Conversation

benjdlambert
Copy link
Contributor

This adds the same labels as the pod gets to both the Deployment and Service for each of the manifests.

Makes it easier to do kubectl get all -l service=color

image

kflynn
kflynn approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Missed this one. Thanks, @benjdlambert!

@kflynn kflynn merged commit d571027 into BuoyantIO:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflynn kflynn kflynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjdlambert @kflynn