Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Issue #2899254: Integrate editorial search with Search API module #434

Open
wants to merge 193 commits into
base: 8.x-2.x
Choose a base branch
from

Conversation

chrfritsch
Copy link
Member

@chrfritsch chrfritsch commented Nov 7, 2017

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@chrfritsch chrfritsch changed the title Feature/2899254 integrate editorial search with search api Issue #2899254: Integrate editorial search with Search API module Nov 7, 2017
Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag based caching breaks second request to contetn view

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several actions are missing on the content list

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the "Fulltext search" box to the front of the form

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add search to media tab and media browser

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing!

…h_with_search_api

* develop:
  Issue #2923124 by daniel.bosen: Remove make.yml files
  Issue #2923094 by daniel.bosen: Thunder Liveblog integration adds unneccesary dependencies
  Issue #2922261 by chr.fritsch: Find unneeded dependencies in optional thunder modules
…api' of github.com:BurdaMagazinOrg/thunder-distribution into feature/2899254-integrate_editorial_search_with_search_api

* 'feature/2899254-integrate_editorial_search_with_search_api' of github.com:BurdaMagazinOrg/thunder-distribution:
…h_with_search_api

* develop:
  Issue #2923328 by daniel.bosen: Cleanup before release (#442)
…h_with_search_api

* develop:
  Issue #2828407 by chr.fritsch, cebasqueira: Configuration menu - many useless menu items for SEO role
  Issue #2915666 by chr.fritsch, maosmurf: Upgrade path for paragraphs split module
  Issue #2915666 by chr.fritsch, maosmurf: Integrate paragraphs split module
  Issue #2924324: Use selenium chrome docker image for tests (#438)
  Issue #2924063 by chr.fritsch: Add liveblog page is not aligned with article design
  Issue #2923350: PHP Notice while adding image (#448)
…h_with_search_api

* 8.x-2.x:
  Follow Up PHPStan: Change path for update tests
  Add phpstan for deprecation testing
…h_with_search_api

* 8.x-2.x:
  Issue #3034656 by indigoxela, daniel.bosen, chr.fritsch: Consider SA-CORE-2019-003 updates (#660)
@ol0lll
Copy link
Member

ol0lll commented Feb 25, 2019

@mtodor:

3 and 4
Cache invalidation is not perfect but not the problem, unfortunately, I added entity tags to the query here: 3034996

Results are out of date because of the asynchronous design of search_api. Rebuilding the index is done after the response is sent and before the service is terminated, the next request (destination) is therefore served from stale index.

chrfritsch and others added 21 commits February 26, 2019 09:11
…api' of github.com:BurdaMagazinOrg/thunder-distribution into feature/2899254-integrate_editorial_search_with_search_api
…h_with_search_api

* 8.x-2.x:
  Issue #3040175 by chr.fritsch, volkerk: The descriptions in updates.yml are misleading
  Issue #3037374: div tag not allowed in translation (#663)
  Issue #3024231 by mtodor, chr.fritsch: Cleanup composer dev dependencies
  Issue #3039132 by chr.fritsch, alexpott: Document drupal quickstart command in README
  Issue #3035812 by daniel.bosen, volkerk: Release Thunder 8.2.35
  Issue #3030724 by chr.fritsch, daniel.bosen: Use revision based scheduler view in Thunder
…h_with_search_api

* 8.x-2.x:
  Issue #3040605 by chr.fritsch, daniel.bosen: Tweak thunder install task logic
  Issue #2947071 by chr.fritsch, mtodor, daniel.bosen: Use update_helper module and remove thunder_updater
  Issue #3041383 by chr.fritsch, daniel.bosen, volkerk: Thunder modules installed hook should not expect module installation order
…api' of github.com:BurdaMagazinOrg/thunder-distribution into feature/2899254-integrate_editorial_search_with_search_api
…h_with_search_api

* 8.x-2.x:
  Issue #2846679 by chr.fritsch, mtodor: Two authors, but only one shown
  Issue #3039151 by chr.fritsch, mtodor: Switch to travis stages
…tion into feature/2899254-integrate_editorial_search_with_search_api
…tion into feature/2899254-integrate_editorial_search_with_search_api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants