-
Notifications
You must be signed in to change notification settings - Fork 38
Issue #2906977: Integrate seo assessments #455
base: 8.x-2.x
Are you sure you want to change the base?
Conversation
…ribution into fix/2906977 * 'fix/2906977' of github.com:BurdaMagazinOrg/thunder-distribution: Releace thunder admin theme with development version (#417) Issue #2913792: Cron failing because of simple_sitemap Issue #2908456 by mtodor: Live blog tests flip flop (#409) Adjusted invalid pinterest ID for tests Adjust release date Adjusted Changelog Issue #2904413: Enabling content translation module results in RuntimeException
…tion into fix/2906977
… schema fails on installs using drush make
…tion into fix/2906977
…tion into fix/2906977
…tion into fix/2906977
* develop: Issue #2828407 by chr.fritsch, cebasqueira: Configuration menu - many useless menu items for SEO role Issue #2915666 by chr.fritsch, maosmurf: Upgrade path for paragraphs split module Issue #2915666 by chr.fritsch, maosmurf: Integrate paragraphs split module Issue #2924324: Use selenium chrome docker image for tests (#438) Issue #2924063 by chr.fritsch: Add liveblog page is not aligned with article design Issue #2923350: PHP Notice while adding image (#448) Add Changelog Issue #2923328 by daniel.bosen: Cleanup before release (#442) Issue #2923124 by daniel.bosen: Remove make.yml files Issue #2923094 by daniel.bosen: Thunder Liveblog integration adds unneccesary dependencies Issue #2922261 by chr.fritsch: Find unneeded dependencies in optional thunder modules
…tion into feature/2906977-integrate-seo-assessments
* develop: (102 commits) Replace GPL-2.0+ by GPL-2.0-or-later Add changelog Issue #2931731 by chr.fritsch, tjwelde: [UX] Field length indicator without setting a hard limit Issue #2936777: Daily tests are failing with Drush 9 Issue #2934289 by chr.fritsch: Update core and contrib Issue #2925486 by chr.fritsch: Previous article paths get not redirected to the current url Fix update path (#476) Issue #2931731 by tjwelde: [UX] Field length indicator without setting a hard limit (#443) Issue #2927525 by alexpott, chr.fritsch: Add update testing using UpdatePathTestBase fix typos update changelog Issue #2931742 by chr.fritsch: Show one split button instead of two Issue #2931007 by chr.fritsch: Thunder installs all optional config after a module install back to develop Check if body field has data Revert "Keep body field" Keep body field FIX CS Improvements Fix docs ...
* develop: Issue #2945809 by chr.fritsch: Update contrib modules Fix wrong exported langcode (#496) Issue #2942861 by chr.fritsch: Tests fail due to content lock update Replace dependency on http://cgit.drupalcode.org with github #2937687: Update screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOAST seo title check differs from our own length indicator. This is confusing for the editor, since we contradict ourselves.
Yoast seems to calculate the actual text width, while we just count the number of charachters.
We need to use a compatible way of calculating the text length with the length indicator.
Either by reverse engeneering it, or by trying to use yoasts javascript directly - if available.
…tion into feature/2906977-integrate-seo-assessments
I added pixel based operation to the length-indicator module: For same title width on length-indicator and yoast_seo, we also need: |
Is this related for us https://www.drupal.org/project/yoast_seo/issues/2992284? |
Make sure these boxes are checked before submitting your pull request - thank you!
If you are really awesome, then your feature is covered by additional tests. Well done!