Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rand version #127

Closed
dhardy opened this issue Jul 24, 2018 · 1 comment
Closed

Update Rand version #127

dhardy opened this issue Jul 24, 2018 · 1 comment

Comments

@dhardy
Copy link

dhardy commented Jul 24, 2018

Regex currently requires Rand ^0.4. Given the extremely limited use by this library, you could probably get away with >= 0.3; I think at least >= 0.3 < 0.7 should be safe.

@dhardy
Copy link
Author

dhardy commented Jul 24, 2018

Sorry, incorrect. But if you replace:

                let numbers: Vec<$numty> =
                    rand::thread_rng().gen_iter().take(100000).collect();

with

   let mut rng = thread_rng();
   let numbers: Vec<$numty> = (0..100000).map(|_| rng.gen()).collect();

you should have no problems. See rust-random/rand#286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant