Remove unsafe code from read_uint and read_uint128 methods #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite read_uint and read_uint128 methods such that they no longer use unsafe code. Rather than casting pointers and doing unsafe copies, declare output byte buffer for the read number and use from_xx_bytes method to convert those read bytes to a number.
BurntSushi
pushed a commit
that referenced
this pull request
Oct 5, 2023
Rewrite read_uint and read_uint128 methods such that they no longer use unsafe code. Rather than casting pointers and doing unsafe copies, declare output byte buffer for the read number and use from_xx_bytes method to convert those read bytes to a number. Closes #192
BurntSushi
pushed a commit
that referenced
this pull request
Oct 5, 2023
Rewrite read_uint and read_uint128 methods such that they no longer use unsafe code. Rather than casting pointers and doing unsafe copies, declare output byte buffer for the read number and use from_xx_bytes method to convert those read bytes to a number. Closes #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite read_uint and read_uint128 methods such that they no longer
use unsafe code. Rather than casting pointers and doing unsafe
copies, declare output byte buffer for the read number and use
from_xx_bytes method to convert those read bytes to a number.