Add bom_sniffing option to DecodeReaderBytesBuilder #5
Conversation
src/lib.rs
Outdated
| let has_detected = !self.bom_override && encoding.is_some(); | ||
|
|
||
| // No need to do BOM detection if we opt out of it or have an explicit encoding. | ||
| let has_detected = !self.bom_sniffing || !self.bom_override && encoding.is_some(); |
There was a problem hiding this comment.
Can you add parens here to indicate precedent?
src/lib.rs
Outdated
| /// the encoding with BOM. | ||
| /// | ||
| /// When this is disabled and an explicit encoding is not set, the decoder will treat the input | ||
| /// as raw bytes. |
There was a problem hiding this comment.
I would add, "The bytes will be passed through unchanged, including any BOM that may be present."
src/lib.rs
Outdated
| let has_detected = !self.bom_override && encoding.is_some(); | ||
|
|
||
| // No need to do BOM detection if we opt out of it or have an explicit encoding. | ||
| let has_detected = !self.bom_sniffing || (!self.bom_override && encoding.is_some()); |
There was a problem hiding this comment.
Sorry, I just noticed this: can you make sure all new code introduced in this is wrapped to 79 columns inclusive? It should follow the existing style of the code. This line in particular is longer than 79. The comments introduced below are also longer than 79 columns.
There was a problem hiding this comment.
Done. I wanted to use cargo fmt at first but didn't know if this repository follows it's rules. Perhaps this tool can be used in the future?
There was a problem hiding this comment.
It'd be nice, but no, I don't think rustfmt is in a place yet for me to adopt it. It does too many sub-optimal things with the formatting.
|
This PR is now in |
|
@BurntSushi Great, thanks. I will work on the "plumbing" part now. :) |
BurntSushi/ripgrep#1207