span: allow ambiguous_negative_literals
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
force-pushed
the
ag/fix-nightly-lint
branch
from
75ad0f8
to
ee4f89f
Compare
|
Ug. There's also a billion doc tests that will need to have this lint |
This was bad timing. The lang team just stabilized (in nightly) a new deny-by-default lint, named `ambiguous_negative_literals`, which triggers an error for things like `-1.hour()`. While such things can be confusingly ambiguous in some cases, in Jiff, `-1.hour()`, `(-1).hour()` and `-(1.hour())` are all, very intentionally, precisely equivalent. For now we just `allow` the lint. If the lint stays, we'll likely want to recommend allowing it in the Jiff docs. See: rust-lang/rust#121364
BurntSushi
force-pushed
the
ag/fix-nightly-lint
branch
from
ee4f89f
to
77f9894
Compare
Urgau
reviewed
Jul 28, 2024
| @@ -1367,6 +1367,8 @@ impl Date { | |||
| /// # Example: negative spans are supported | |||
| /// | |||
| /// ``` | |||
| /// # // See: https://github.com/rust-lang/rust/pull/121364 | |||
| /// # #![allow(unknown_lints, ambiguous_negative_literals)] | |||
There was a problem hiding this comment.
All of those manual allow-attr can be replaced with a single #![doc(test(attr(...)))] attr: #![doc(test(attr(allow(unknown_lints, ambiguous_negative_literals))))]
There was a problem hiding this comment.
Oh wow, that's great to know! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was bad timing. The lang team just stabilized (in nightly) a new
deny-by-default lint, named
ambiguous_negative_literals, whichtriggers an error for things like
-1.hour(). While such things can beconfusingly ambiguous in some cases, in Jiff,
-1.hour(),(-1).hour()and
-(1.hour())are all, very intentionally, precisely equivalent.For now we just
allowthe lint. If the lint stays, we'll likely wantto recommend allowing it in the Jiff docs.
See: rust-lang/rust#121364