Support MIRI by using naive implementations
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #51 Some reordering was introduced in `cfg` attributes to make it consistent
|
Woops, looking into breakage |
BurntSushi
requested changes
Feb 12, 2020
src/lib.rs
Outdated
| target_arch = "x86_64", | ||
| memchr_runtime_simd, | ||
| memchr_libc | ||
| )))] |
There was a problem hiding this comment.
I think this is your issue. I think you want:
#[cfg(all(
not(memchr_libc),
not(all(target_arch = "x86_64", memchr_runtime_simd)),
not(miri),
))]
There was a problem hiding this comment.
Yep, !A && !(B && C) is (!A && !B) || (!A && !C) 🤦♂️
src/lib.rs
Outdated
| #[inline(always)] | ||
| fn imp(n1: u8, haystack: &[u8]) -> Option<usize> { | ||
| x86::memchr(n1, haystack) | ||
| } | ||
|
|
||
| #[cfg(all( | ||
| memchr_libc, | ||
| not(all(target_arch = "x86_64", memchr_runtime_simd)) | ||
| not(all(miri, target_arch = "x86_64", memchr_runtime_simd)) |
There was a problem hiding this comment.
When using similar cfg knobs, could you make sure they are in the same order? e.g., I'd put miri last here, in order to match all(target_arch = "x86_64", memchr_runtime_simd, not(miri)) above.
BurntSushi
approved these changes
Feb 12, 2020
|
This is on crates.io in |
|
Thanks for the crate, the help and the responsiveness! Much appreciated |
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Some reordering was introduced in
cfgattributes to make it consistentbecomes
It highlights which component of the conditional is important/introduced by putting them first