minor fixes & set version policy to "latest stable release of Rust" #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
force-pushed
the
ag/various-fixes
branch
from
6c0a42d
to
1059421
Compare
BurntSushi
commented
Aug 22, 2018
complete/_rg
Outdated
| @@ -167,7 +167,7 @@ _rg() { | |||
|
|
|||
| + '(pcre2-unicode)' # PCRE2 Unicode options | |||
| $no'(--no-pcre2-unicode)--pcre2-unicode[enable PCRE2 Unicode mode (with -P)]' | |||
| '(--no-pcre2-unicode)--no-pcre2-unicode[disable PCRE2 Unicode mode (with -P)]' | |||
| '(--pcre2-unicode)--no-pcre2-unicode[disable PCRE2 Unicode mode (with -P)]' | |||
There was a problem hiding this comment.
cc @okdana I made this change based on your docs. Let me know if I got this wrong!
There was a problem hiding this comment.
Oh, i was the one who got it wrong actually, sorry. :/
Neither of those exclusions are necessary since we've got the parentheses around the group name, but i had intended to exclude --no-pcre2 (because there's no reason you'd change the PCRE2 Unicode mode if you were just going to disable PCRE2 anyway). I guess i just wasn't paying attention.
So both of the options in that group should actually have (--no-pcre2).
BurntSushi
force-pushed
the
ag/various-fixes
branch
2 times, most recently
from
1059421
to
15b0005
Compare
Previously, we used --pcre2-unicode as the canonical flag despite the fact that it is enabled by default, which is inconsistent with how we handle other similar flags. The reason why --pcre2-unicode was made the canonical flag was to make it easier to discover since it would be sorted near the --pcre2 flag. To solve that problem, we simply start a convention that lists related flags in the docs. Fixes #1022
This also updates some code to make use of our more liberal versioning requirement, including the use of crossbeam-channel instead of the MsQueue from the older an unmaintained crossbeam 0.3. This does regrettably add a sizable number of dependencies, however, compile times seem mostly unaffected. Closes #1019
This commit undoes a work-around for a bug in Rust's standard library that prevented correct file type detection on Windows in OneDrive directories. We remove the work-around because we are moving to a latest-stable Rust version policy, which has included this fix for a while now. ref #705, rust-lang/rust#46484
This fixes warnings and adds an additional invalid UTF-8 test that will run on Windows.
When emitting color, the printer wasn't checking whether the line exceeded the maximum allowed length.
This now mentions PCRE2 support.
This commit beefs up the package metadata used by the 'cargo deb' tool to produce a binary dpkg. In particular, we now include ripgrep's man page. This commit includes a new script, 'ci/build_deb.sh', which will handle the build process for a dpkg, which has become a bit more nuanced than just running 'cargo deb'. We don't (yet) run this script in CI. Fixes #842
This commit fixes a bug where the first path always reported itself as as symlink via `path_is_symlink`. Part of this fix includes updating walkdir to 2.2.1, which also includes a corresponding bug fix. Fixes #984
BurntSushi
force-pushed
the
ag/various-fixes
branch
from
15b0005
to
538dd22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a smattering of minor fixes and cleanups. The biggest change here is actually putting #1019 into action and changing ripgrep's minimum Rust version policy to the latest stable release.
Fixes #842
Fixes #953
Fixes #984
Fixes #1019
Fixes #1022
ref #705