add --one-file-system, --sort and --sortr #1027
Conversation
|
No errors in the stuff you added, but:
|
|
btw, to give some context for the changes you're making:
|
This commit adds a 'same_file_system' option to the walk builder. For single threaded walking, it defers to the walkdir crate, which has the same option. The bulk of this commit implements this flag for the parallel walker. We add one very feeble test for this. The parallel walker is now officially a complete mess. Closes #321
This permits callers to sort entries by their full file path, which makes it easy to query for various file statistics. It would have been better to provide a comparator on DirEntry itself, similar to how walkdir does it, but this seems to require quite a bit of work to make the types work out, assuming we want to continue to use walkdir's sorting support (we do).
These flags each accept one of five choices: none, path, modified, accessed or created. The value indicates how the results are sorted. For --sort, results are sorted in ascending order where as for --sortr, results are sorted in descending order. Closes #404
BurntSushi
force-pushed
the
ag/features
branch
from
a2f70b0
to
3ddd286
Compare
|
@okdana I think I've fixed all of that! Also, I spent half a day yak shaving. My default shell is now zsh. Let's see how this goes. :-) |
|
@okdana I am pretty blown away by the auto completing for |
|
Thanks! Let me know if you need anything re: zsh |
|
@okdana I think I might take you up on that! I sent you mail. :-) |
Closes #321, Closes #404
cc @okdana Mind checking if I got the completions right? If I got it this time, then I think I've grok'd it.