Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow (and ignore) whitespace-only lines in .gitignore files #104

Closed
wants to merge 1 commit into from

Conversation

ddrcoder
Copy link

Git considers these to be blank lines.

@ddrcoder
Copy link
Author

Without this, it panics at the ..unwrap() == '/' on line 301.

@BurntSushi
Copy link
Owner

@ddrcoder Thanks! This looks OK, but could you add a regression test please?

@BurntSushi
Copy link
Owner

BurntSushi commented Sep 26, 2016

I merged this in ebabe1d with a regression test. Sorry about being impatient, but I wanted to get this bug fixed with a new release out tonight. Thanks so much for catching this and fixing it!

@BurntSushi BurntSushi closed this Sep 26, 2016
@ddrcoder
Copy link
Author

Sorry I couldn't get back to this yesterday. I'm glad you didn't wait on my account. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants