Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve symbolic links for all input files #257

Closed
wants to merge 1 commit into from

Conversation

jFransham
Copy link

@jFransham jFransham commented Nov 29, 2016

Closes #256.

Question: is this the right place to do this? This gives paths an IO/filesystem dependency that it didn't already have, which makes this function impure when you might expect it to return the same thing each time.

@BurntSushi
Copy link
Owner

Sorry for the late reply! Unfortunately, this bug is a bit more complex to fix. Canonicalizing all of the paths like this is a non-starter, since the output will use all of the canonicalized paths instead of their logical paths. The right solution here is to read file paths given at the command line as if they were normal files, which required fixing the underlying recursive directory iterators. For example, see: BurntSushi/walkdir#15

I'll be pushing a fix soon!

@BurntSushi BurntSushi closed this Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants