Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates (path operand, &c.) #728

Merged
merged 4 commits into from
Jan 11, 2018

Conversation

okdana
Copy link
Contributor

@okdana okdana commented Jan 1, 2018

Fixes #725 (i guess?)

  • I capitalised the place-holders options and path to make them consistent with PATTERN &al.

  • I added documentation of the positional arguments to the man page

  • I added a note to both the man page and the usage help to clarify that an explicit PATH overrides glob/ignore rules. This could possibly be clearer i guess — a glob/ignore rule is only overridden if the path as given on the command line contains a segment that actually matches it — but it didn't seem worth writing a whole paragraph about

  • I'm not sure when this became an issue, but when i regenerated the man page all of the long option names were broken — Pandoc had converted --foo into –foo (with an en dash). I updated convert-to-man to disable 'smart typography', which seems to have fixed it for Pandoc 2.0.6; hopefully it doesn't cause issues for contributors on older versions

Fixes BurntSushi#725 (sort of)

* Capitalise place-holder names consistently
* Document PATTERN and PATH
* Add note about PATH overriding glob/ignore rules
Fixes BurntSushi#725 (sort of)

* Capitalise place-holder names consistently
* Add note about PATH overriding glob/ignore rules
@BurntSushi
Copy link
Owner

RE ci failures: My bet is on the capitalization of path.

@okdana
Copy link
Contributor Author

okdana commented Jan 1, 2018

lol, oops. Should have done a more thorough test than just rg --help i guess.

Pushed a fix, it seems better now.

@okdana okdana mentioned this pull request Jan 10, 2018
@BurntSushi BurntSushi merged commit 34c0b1b into BurntSushi:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glob ignored for items in path
2 participants