Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply select clippy perf lints #374

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Apply select clippy perf lints #374

wants to merge 9 commits into from

Commits on Aug 15, 2024

  1. clippy: redundant_field_names 

    https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ebf4040 View commit details
    Browse the repository at this point in the history

  2. clippy: assign_op_pattern 

    https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6cba81c View commit details
    Browse the repository at this point in the history

  3. clippy: unnecessary_cast 

    https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    696e46c View commit details
    Browse the repository at this point in the history

  4. clippy: manual_memcpy 

    https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c66bf2b View commit details
    Browse the repository at this point in the history

  5. clippy: nonminimal_bool 

    https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    048ac75 View commit details
    Browse the repository at this point in the history

  6. clippy: map_clone 

    https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c78c9d3 View commit details
    Browse the repository at this point in the history

  7. clippy: manual_strip 

    https://rust-lang.github.io/rust-clippy/master/index.html#/manual_strip
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    876c405 View commit details
    Browse the repository at this point in the history

  8. clippy: useless_conversion 

    warning: useless conversion to the same type: `&str`
   --> src/deserializer.rs:428:58
    |
428 |         self.next_field().and_then(|f| visitor.visit_str(f.into()))
    |                                                          ^^^^^^^^ help: consider removing `.into()`: `f`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    da9cf34 View commit details
    Browse the repository at this point in the history

  9. clippy: another useless_conversion 

    warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/string_record.rs:667:33
    |
667 |         StringRecord::from_iter(xs.into_iter())
    |                                 ^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `xs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/13a52890dde8cfeb95069d77c223ac37c0cf3a46/library/core/src/iter/traits/collect.rs:152:21
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    @jqnatividad
    jqnatividad committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b4b3d71 View commit details
    Browse the repository at this point in the history