Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove atty recommendation #73

Closed
daboross opened this issue Mar 23, 2023 · 2 comments
Closed

Remove atty recommendation #73

daboross opened this issue Mar 23, 2023 · 2 comments

Comments

@daboross
Copy link

daboross commented Mar 23, 2023 •
edited
Loading

It looks like atty has a reported possible unsoundness when using a custom global allocator, and hasn't updated to fix it: https://rustsec.org/advisories/RUSTSEC-2021-0145.html / softprops/atty#50.

I think it could be reasonable to replace the atty recommendation in the detecting-presence-of-a-terminal docs with an alternative, potentially is-terminal.
@BurntSushi
Copy link
Owner

Have you seen #70?

@LunNova
Copy link

LunNova commented Aug 24, 2023

https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html is part of std now

BurntSushi added a commit that referenced this issue Sep 19, 2023
@BurntSushi
doc: remove recommendation for atty
955235d 
We replace it with a recommendation to use the standard
library.

Fixes #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BurntSushi @LunNova @daboross