Update windows-sys to version 0.59.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Aug 2, 2024
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "winapi-util" | |||
| version = "0.1.8" #:version | |||
| version = "0.1.8" #:version | |||
There was a problem hiding this comment.
I think this was not intended?
There was a problem hiding this comment.
Oh, oops. Auto format is a pain sometimes.
| @@ -13,7 +13,7 @@ categories = ["os::windows-apis", "external-ffi-bindings"] | |||
| edition = "2021" | |||
|
|
|||
| [target.'cfg(windows)'.dependencies.windows-sys] | |||
| version = "0.52.0" | |||
| version = ">=0.48.0, <=0.59.*" | |||
There was a problem hiding this comment.
OK, so my initial reaction to this was that libraries shouldn't be setting upper bounds. But this looks like it is strictly more flexible than 0.59.0. Which I think makes sense to me.
There was a problem hiding this comment.
Yeah. I just wanted to make sure that all sem-ver compatible point releases would be included without also including arbitrary future breaking releases. I could have also used <0.60.0 but I thought it was a bit clearer to write the current version rather.
ChrisDenton
force-pushed
the
windows-sys-0-59
branch
from
742763c to
26020f7
Compare
BurntSushi
approved these changes
Aug 2, 2024
|
This is on crates.io in |
BurntSushi
added a commit
to BurntSushi/jiff
that referenced
this pull request
Aug 18, 2024
This matches a similar change made by @ChrisDenton for winapi-util in: BurntSushi/winapi-util#19 The benefit is that this should hopefully put less constraints on the ecosystem and to enable fewer copies of windows-sys to appear in dependency trees. I am somewhat miffed that this is necessary. IMO, the windows-sys maintainers should find a way to make a stable release with infrequent or ~zero breaking change releases.
BurntSushi
added a commit
to BurntSushi/jiff
that referenced
this pull request
Aug 18, 2024
This matches a similar change made by @ChrisDenton for winapi-util in: BurntSushi/winapi-util#19 The benefit is that this should hopefully put less constraints on the ecosystem and to enable fewer copies of windows-sys to appear in dependency trees. I am somewhat miffed that this is necessary. IMO, the windows-sys maintainers should find a way to make a stable release with infrequent or ~zero breaking change releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this release include making the
HANDLEtype match rust's std type (i.e.*mut c_voidinstead ofisize).If it's ok with you, I've used a range dependency so that it is less likely that multiple versions of
windows-sysappear in someone's dependency tree. According to the stats, the last 3 versions (0.48.0. 0.52.0 and 0.59.0) account for most uses ofwindows-sys. I have tested that these versions work.This shouldn't need to be updated often. The last release (0.52.0) was 9 months ago.