Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some units (Reaper grenade) to effects #5

Open
3 of 5 tasks
BurnySc2 opened this issue Jun 8, 2019 · 2 comments
Open
3 of 5 tasks

Change some units (Reaper grenade) to effects #5

BurnySc2 opened this issue Jun 8, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@BurnySc2
Copy link
Owner

BurnySc2 commented Jun 8, 2019

  • Reaper grenade should be an effect and not a structure
  • Parasitc bomb (after the unit has died, the effect still lives on as a unit) should be an effect
  • Force field should be an effect not a unit

This can probably be achieved here

for unit in self.state.observation_raw.units:

by removing them from units and adding them to self.state.effects

  • Fix ravager bile effect
    While we are at it, the ravager bile is removed from the API too early before the bile has landed on the destination. Units will no longer try to dodge this and will probably take damage. This might need to be stored for a couple frames, or should this be handled bot specifically?
  • Tactical Nuke probably has the same problem
@BurnySc2 BurnySc2 added the enhancement New feature or request label Jun 8, 2019
@tweakimp tweakimp self-assigned this Jun 8, 2019
@tweakimp
Copy link

tweakimp commented Jun 8, 2019

Completed first three tasks in 034b71a

@tweakimp
Copy link

tweakimp commented Jun 9, 2019

Added Nuke to task list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants