Add V2 Typings to JS SDK #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcinpece-apptension
commented
Oct 31, 2024
•
marcinpece-apptension
commented
Add V2 Typings to JS SDK
Add V2 Typings to JS SDK
marcinpece-apptension
force-pushed
the
2549-add-v2-typings-to-js-sdk
branch
2 times, most recently
from
d54e068
to
893b8af
Compare
marcinpece-apptension
force-pushed
the
2549-add-v2-typings-to-js-sdk
branch
from
893b8af
to
1e48a7a
Compare
|
@courcelan per Marcin, this is complementary to the PR the agency opened |
courcelan
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@ViolanteCodes these look good, we just need to ensure that the status type doesn't get overwritten by this one... so lets merge #106 into here and then use this one to merge into master.
ViolanteCodes
force-pushed
the
2549-add-v2-typings-to-js-sdk
branch
from
41e12ab
to
a1f0c17
Compare
ViolanteCodes
force-pushed
the
2549-add-v2-typings-to-js-sdk
branch
from
a1f0c17
to
41e2fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.