Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Adds Visual Flow #114

Merged
merged 22 commits into from
Dec 21, 2021
Merged

🎉 Adds Visual Flow #114

merged 22 commits into from
Dec 21, 2021

Conversation

AlexandreSajus
Copy link
Contributor

2021-12-12.03-28-50_1.mp4

Pressing a run button will now highlight in green the graph traversal that is made to gather the blocks to run
Running blocks are now highlighted in red

Closes #66

@AlexandreSajus AlexandreSajus added the enhancement New feature or request label Dec 12, 2021
@AlexandreSajus AlexandreSajus self-assigned this Dec 12, 2021
@AlexandreSajus
Copy link
Contributor Author

visual.flow.4.mp4

I have modified the behavior so that all of the left transmitting animations start at the same time. Perhaps this looks better.

Also Codacy is angry and I can't find out why

@AlexandreSajus
Copy link
Contributor Author

Requested changes:

  • The green transmitting effect should be done according to distance to the block (1: the block, 2: the connected edges, 3: the blocks connected by the edges from 2,...)
  • A block that will be executed should stay green until it is run
  • The execution and the red running effect should start at the end of the green transmitting effect
  • Animation speed should be easily controllable for further testing

Gimme a minute...

@AlexandreSajus AlexandreSajus removed the request for review from MathisFederico December 20, 2021 09:42
@vanyle
Copy link
Contributor

vanyle commented Dec 20, 2021

Merge failed ... Git adds back functions into codeblock that belong inside executionblock, like:

  • run_left
  • run_right
  • _interrupt_execution
  • ...

Try to move as much flow code into the executableblock as other block types like the slider might enjoy having those.
For example, the transmitting_queue variable and all methods dealing with it should be in the executableblock class.

@AlexandreSajus
Copy link
Contributor Author

Added requested changes:

visual_flow.mp4

Looks much better now

A check fails for no reason, the feature works in local

@vanyle vanyle self-requested a review December 20, 2021 22:02
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
tests/integration/blocks/test_flow.py Outdated Show resolved Hide resolved
tests/integration/blocks/test_flow.py Outdated Show resolved Hide resolved
tests/integration/blocks/test_flow.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
@vanyle
Copy link
Contributor

vanyle commented Dec 20, 2021

The way github shows the code snippets attached to review comment is misleading. This view is better:
https://github.com/Bycelium/PyFlow/pull/114/files/042b491bd387ee6fd719eacd56627a5f2d6c61dd#diff-4e9f706551f31121752e22f2c9a3b78b9874e6008a0ab0356a02a3128be84872

@AlexandreSajus AlexandreSajus removed the request for review from MathisFederico December 21, 2021 14:11
Copy link
Contributor

@vanyle vanyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !

@AlexandreSajus AlexandreSajus merged commit 795c111 into master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual execution flow
2 participants