Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Restrict file loading to .ipyg and .ipynb #223

Merged
merged 2 commits into from
Jan 16, 2022
Merged

🎉 Restrict file loading to .ipyg and .ipynb #223

merged 2 commits into from
Jan 16, 2022

Conversation

FabienRoger
Copy link
Contributor

Fixes #156

MathisFederico
MathisFederico requested changes Jan 15, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to restrict what files can be opened in the first place, although a better tooltip is welcome !

pyflow/graphics/window.py Outdated Show resolved Hide resolved
@MathisFederico MathisFederico changed the title 🪲 Change file dialog settings 🎉 Restrict file loading to .ipyg and .ipynb Jan 15, 2022
@FabienRoger
Copy link
Contributor Author

This does restrict the files that can be opened!

MathisFederico
MathisFederico approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@MathisFederico MathisFederico merged commit 5be101a into dev Jan 16, 2022
@MathisFederico MathisFederico deleted the bugfix/display-right-files branch January 16, 2022 13:58
@MathisFederico MathisFederico linked an issue Jan 16, 2022 that may be closed by this pull request
Opening file with wrong extension should prompt an error #211
Closed
@MathisFederico MathisFederico mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisFederico MathisFederico MathisFederico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening file with wrong extension should prompt an error Open... should restrict what files can be opened
2 participants
@FabienRoger @MathisFederico