🎉 Add prompt before exiting the program #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisFederico
requested changes
Feb 16, 2022
pyflow/graphics/window.py
Outdated
Comment on lines
463
to
479
| quit_msg = "Exit without saving?" | ||
| msgbox = QMessageBox(self) | ||
| msgbox.setText(quit_msg) | ||
| msgbox.setWindowTitle("Exit?") | ||
| msgbox.addButton(QMessageBox.Yes) | ||
| msgbox.addButton(QMessageBox.No) | ||
| cb = QCheckBox("Never show this again") | ||
| msgbox.setCheckBox(cb) | ||
| msgbox.exec() | ||
|
|
||
| if msgbox.checkBox().checkState() == Qt.CheckState.Checked: | ||
| self.never_show_exit_prompt = True | ||
|
|
||
| if msgbox.result() == int(str(QMessageBox.No)): | ||
| event.ignore() | ||
| return | ||
|
|
There was a problem hiding this comment.
This should replace self.maybeSave
There was a problem hiding this comment.
I feel like maybeSave is not exactly what we want. First, it doesn't have the checkbox, (and I really don't want to have the exit prompt when trying out the new features I am coding). Second, it isn't clear what should be saved, and how, when there are multiple open widgets, especially when some of them have never been saved.
I believe maybeSave is an outdated function that only worked when it was developed, when there was only one single widget.
There was a problem hiding this comment.
But we should delete it and not comment it then !
MathisFederico
requested changes
Feb 16, 2022
pyflow/graphics/window.py
Outdated
Comment on lines
503
to
504
| # def maybeSave(self) -> bool: | ||
| # """Ask for save and returns if the file should be closed. |
There was a problem hiding this comment.
Suggested change
| # def maybeSave(self) -> bool: | |
| # """Ask for save and returns if the file should be closed. |
We should delete it I guess
MathisFederico
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216