Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 🎨 Add persistent colors #276

Merged
merged 21 commits into from
Feb 19, 2022
Merged

Conversation

MathisFederico
Copy link
Member

Add persistent colors to ease the user comprehension and let him remember what was run. Fixes #272
Refactored 'run_state' and 'has_been_run' using Enum for better maintenance.

@FabienRoger
Copy link
Contributor

The outline was barely visible!
Also, the edges don't light up anymore. Is that on purpose?
But with this feature it is much much easier to see what is going on (and much easier to see that "run right" is broken, and runs cells multiple times...).

@MathisFederico
Copy link
Member Author

MathisFederico commented Feb 17, 2022

The outline was barely visible!

Maybe on larger screens indeed !

Also, the edges don't light up anymore. Is that on purpose?

Yes !

But with this feature it is much much easier to see what is going on (and much easier to see that "run right" is broken, and runs cells multiple times...).

Indeed ! Well spotted !

@FabienRoger
Copy link
Contributor

Indeed ! Well spotted !

This was a bug introduced by this PR, so I fixed it here.

FabienRoger
FabienRoger previously approved these changes Feb 18, 2022
@MathisFederico MathisFederico merged commit af0f810 into dev Feb 19, 2022
@MathisFederico MathisFederico deleted the feature/persistent_colors branch February 19, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent execution feedback
2 participants