fix: implement app:textClearHistory
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by Android Studio, required to build then obtained error: ``` Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module @4dbd62bc ``` Fixed by updating build tools to 7.0.X, (this is the first release which supports 7.2 according to https://stackoverflow.com/a/70807648/
Previously the XML attribute has no effect on the <com.bytehamster.lib.preferencesearch.SearchPreference /> element tested with: ``` Index: app/src/main/res/xml/preferences.xml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml --- a/app/src/main/res/xml/preferences.xml (revision 856ae2c) +++ b/app/src/main/res/xml/preferences.xml (date 1707366854942) @@ -1,7 +1,9 @@ <?xml version="1.0" encoding="utf-8"?> -<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"> +<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" + xmlns:app="http://schemas.android.com/apk/res-auto"> <com.bytehamster.lib.preferencesearch.SearchPreference + app:textClearHistory="AA" android:key="searchPreference" /> <CheckBoxPreference = ``` Fixes 33
5 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the XML attribute has no effect on the
<com.bytehamster.lib.preferencesearch.SearchPreference />elementapp:textClearHistoryhas no effect #33tested with the following on my S21 (thanks so much for the example repo):
Relevant commit: dbdbcb4
testing + patch
I added a gradle wrapper upgrade in here as I needed it to get the repo to compile on my machine, feel free to drop this.
For clarity: patch is licensed under MIT & you have full permission to relicense as you see fit
Problem was introduced in 4532977