This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Add autoannounce-feature to dates-plugin #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izzy
reviewed
Mar 4, 2017
config.ini.example
Outdated
| # timedelta = 21 | ||
| # announce_minutes = 60,1440 |
There was a problem hiding this comment.
It's not instantly clear what this will do - so it either would need a comment or better a simple array so it's clear those are multiple times like so:
announce_minutes = 60
announce_minutes = 1440
# announce_minutes = [time]
There was a problem hiding this comment.
multiple values are not possible, you can just add something like
announce_minutes =
60
1440
Added some documentation to configuration...
There was a problem hiding this comment.
I realized just now my example was missing the square brackets after the variable name m( Should've been:
announce_minutes[] = 60
announce_minutes[] = 1440
# announce_minutes[] = [time]There was a problem hiding this comment.
# Minutes in the future to show event announcement (list of multiple values)
announce_minutes[] = 60
announce_minutes[] = 1440results in
configparser.DuplicateOptionError: While reading from 'config.ini' [line 99]: option 'announce_minutes[]' in section 'plugins.dates' already exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes: