Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core-windows.py #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update core-windows.py #42

wants to merge 2 commits into from

Conversation

Windows81
Copy link
Contributor

These sets of changes allow the text-to-speech to play in a higher-quality manner.

@C-Loftus
Copy link
Owner

Thanks for your PR. Could you provide more context for what is wrong / bad currently and how this fixed it? I have not had issues with the current implementation. However I only tested on Windows 10 so maybe something has changed.

I looked at the auto hotkey link in the comment but did not see an explanation.

@C-Loftus
Copy link
Owner

Don't have a windows machine atm, so going to wait on merging this until I can test properly. But based on your comments in #43 I am unsure if this is the right fit. Since sight-free-talon is primarily focused on low vision / screen reader use, I think the current standard SAPI5 voices are sufficient and have faster start and cancel speed compared to some of the more natural sounding voices.

That being said, I will wait to test latency and keep this open since I could very well be wrong. Also feel free to send me your use case if I am missing something. (i.e. are you trying to read things out for accessibility / eyestrain reasons, for general multitasking, voice assistant purposes, something else etc)

@Windows81
Copy link
Contributor Author

Hey. I accidentally sent my replies to #43. You correctly pointed out that they were meant for this pull request.

I'm using Talon as a voice assistant and have no eye problems at the moment. It'd nice to hear an audio confirmation that what I'm saying is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants