Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported the WHOLE game to vitrix engine #53

Merged
merged 9 commits into from
May 14, 2022
Merged

Ported the WHOLE game to vitrix engine #53

merged 9 commits into from
May 14, 2022

Conversation

Evhann
Copy link
Collaborator

@Evhann Evhann commented May 8, 2022

No description provided.

@Evhann Evhann added Enhancement New feature or request Dependencies Pull requests that update a dependency file labels May 8, 2022
@Evhann Evhann requested a review from C0rupted May 8, 2022 18:51
C0rupted
C0rupted reviewed May 9, 2022
View reviewed changes
Copy link
Owner

@C0rupted C0rupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking okay, just making a few changes with the engine for some finishing touches and bug fixes. Then I'll check out if it works with the new engine

@Evhann
Copy link
Collaborator Author

Evhann commented May 9, 2022

do i merge?

@C0rupted
Copy link
Owner

C0rupted commented May 10, 2022 •
edited
Loading

do i merge?

No, not just yet. I've got a few fixes to the engine I'd like to make before we can merge. Once complete, and thorough testing is done, I will merge it. Its a BIG change, so we need to check for lots of bugs and other issues

C0rupted
C0rupted approved these changes May 13, 2022
View reviewed changes
Copy link
Owner

@C0rupted C0rupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this all works for me, I have made my changes and this PR has my stamp of approval!

@C0rupted C0rupted mentioned this pull request May 13, 2022
Merged
@C0rupted
Copy link
Owner

Merging...

@C0rupted C0rupted merged commit 21fb5dd into C0rupted:dev May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rupted C0rupted C0rupted approved these changes

Assignees
No one assigned
Labels
Dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evhann @C0rupted