Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper Left Buttons not Disabled while Main Menu is Open #123

Open
maxpetul opened this issue Mar 5, 2022 · 2 comments
Open

Upper Left Buttons not Disabled while Main Menu is Open #123

maxpetul opened this issue Mar 5, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@maxpetul
Copy link
Collaborator

maxpetul commented Mar 5, 2022

While in game, if you click the upper-left main menu button repeatedly without closing the menu, multiple main menus will be created and opened next to one another. Similarly you can click to open the advisor screen while the main menu is open.

@maxpetul maxpetul added the bug Something isn't working label Mar 5, 2022
@WildWeazel
Copy link
Member

I see that we're reimplementing Popup which I assume is for the custom background. Godot's Popup is modal by default with multiple display options, and may be better to inherit from than TextureRect.

@QuintillusCFC
Copy link
Member

Well, the original reason we were "reimplementing" popup was that I didn't realize Godot had a built-in popup when I first decided to add a popup. But yes, the challenge with moving to the standard one at this point would be the style, and that some of them (such as Build City) are semi-custom in functionality.

I haven't examined the main menu one up close yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants