Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot 4] Fix Popup Bugs #414

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[Godot 4] Fix Popup Bugs #414

merged 2 commits into from
Apr 12, 2024

Conversation

pcen
Copy link
Contributor

@pcen pcen commented Jul 9, 2023

Incrementally removing bugs from the godot4 branch:

  • prevents polling for input actions in Game.cs when a popup is visible
  • fixes behaviour when the build city popup is open and esc. is pressed: before it would close the popup and show the exit game popup at the same time. now, the first esc. press will only close the current popup

@pcen pcen changed the title fix popup bugs Fix Popup Bugs Jul 9, 2023
@pcen pcen marked this pull request as ready for review July 9, 2023 15:27
@pcen pcen requested a review from WildWeazel July 9, 2023 17:06
@pcen pcen changed the title Fix Popup Bugs [Godot 4] Fix Popup Bugs Jul 9, 2023
@pcen pcen added the bug Something isn't working label Jul 9, 2023
C7/Game.cs Outdated Show resolved Hide resolved
@pcen pcen force-pushed the pcen/fix-popup-bugs branch from 243d2a4 to 83dfffb Compare September 17, 2023 23:57
@pcen
Copy link
Contributor Author

pcen commented Sep 18, 2023

discovered #424 while cleaning up this change

@Sean-Brown
Copy link
Contributor

Getting back into this and not very familiar with all the SDKs involved, but the code changes still make sense to me.

@QuintillusCFC QuintillusCFC added the godot4 PRs targeting Godot 4 branch label Mar 22, 2024
@QuintillusCFC
Copy link
Member

Reviewed code, the changes make sense, and should prevent the multi-popup issue generally. Approved and merging.

@QuintillusCFC QuintillusCFC merged commit 8e9feff into godot4 Apr 12, 2024
@QuintillusCFC QuintillusCFC deleted the pcen/fix-popup-bugs branch April 12, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working godot4 PRs targeting Godot 4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants