Support a barebones "city screen" view #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerner
force-pushed
the
twrner/initial-city-screen
branch
from
f317477 to
df4eeec
Compare
esbudylin
reviewed
Jan 31, 2025
| if (!unit.canBuildCity()) { | ||
| log.Warning($"can't build city at {unit.location}"); | ||
| return; | ||
| return null; |
There was a problem hiding this comment.
Perhaps we could return a nullable type from this method to enhance type safety.
esbudylin
approved these changes
Jan 31, 2025
This is triggered when building a city and when clicking "zoom to city" For now I've just added the "exit" button, but hope to add tile yields soon. I also fixed an issue with the advisor and input handling - previously if you exited the advisor via escape the game would ask if you wanted to exit. Now it works properly.
TomWerner
force-pushed
the
twrner/initial-city-screen
branch
from
df4eeec to
2c2c21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is triggered when building a city and when clicking "zoom to city"
For now I've just added the "exit" button, but hope to add tile yields soon.
I also fixed an issue with the advisor and input handling - previously if you exited the advisor via escape the game would ask if you wanted to exit. Now it works properly.
This will hopefully yield additional good starter PRs - there's lots of labels and icons to place on this screen.