Add option for user to select browser type to use for browser based authentication #265

sandersaelmans · 2020-12-08T12:40:57Z

Issue

Currently a SFSafariViewController is used for browser based authentication. This is fine as long as cookie sharing is not needed between multiple browser instances; However some social logins, especially ones using the app to authenticate the user, require these cookies to be shared. As of iOS 11, SFSafariViewController does not share cookies with the Safari app, nor any other browser instance. As of iOS 11 Apple introduced dedicated authentication sessions to handle authenticating a user through a social login: SFAuthenticationSession(deprecated), and shortly after ASWebAuthenticationSession.

Changes

This PR adds the option for users to select which type of browser based authentication type they want to use SFSafariViewController or ASWebAuthenticationSession. The latter is only available if the user is running on a target which supports it (>= iOS 12, >= OSX 10.15).

This can be done by setting it on the top level MAS object:

// objc
[MAS preferredBrowserBasedAuthenticationType:MASBrowserBasedAuthenticationTypeSafari];

// swift
MAS.preferredBrowserBasedAuthenticationType(.safari)

Upon starting browser based authentication, the preferred browser type will be used, instead of the default SFSafariViewController.

Future Changes

Currently there is a gap for iOS 11 users, as ASWebAuthenticationSession is still available from iOS 12 and onwards. We could opt to also support the deprecated SFAuthenticationSession if needed.

Merge Stable into Master

* Stable: Update CHANGELOG.md

* Stable: (23 commits) Update CHANGELOG.md MASFoundation : removing the library that is no longer being used MASFoundation : version update for 1.6.10 release Copy edits for clarity US461954 : [iOS][MASFoundation] Refactor MASRequest Invoke's Response Structure Removed set parameters methods Copy edits US461954 : [iOS][MASFoundation] Refactor MASRequest Invoke's Response Structure [iOS][MASFoundation] ChangeLog update Deprecated additional methods. Fix for issue described in DE346442 [DE343807] App crash fixed [DE343807] Fixed app crash with startWithURL US436059 : [iOS] Allow MQTT connections to servers with public cert - update for code review’s change requests DE339566 : [iOS][MASFoundation] - issue sending special character like "&" or "+" for login password US436059 : [iOS][MASFoundation] MQTT to fix some delegation, and block handler DE331046 : [iOS][MASFoundation] : Device name in DN DE331046 : [MASFoundation][iOS] Device name for DN US436059 : [iOS] Allow MQTT connections to servers with public cert - code cleanup US436059 : [iOS] Allow MQTT connections to servers with public cert - adding reconnection management ...

Updated changelog for 1.9.20

# Conflicts: # CHANGELOG.md

Merge develop

MAS 2.1.00 release merge

…e for browser based authentication

ysd24

We came to this method "handleAuthorizationResponseURL" through a custom scheme. We might need to evaluate if 'callbackURLScheme' could be used too.

ysd24 · 2020-12-16T11:07:14Z

MASFoundation/Classes/_private_/models/MASWebSessionBrowserBasedAuthentication.m

+{
+    self.session = [[ASWebAuthenticationSession alloc] initWithURL:url callbackURLScheme:nil completionHandler:^(NSURL * _Nullable callbackURL, NSError * _Nullable error) {
+        if (callbackURL != nil) {
+            [MASAuthorizationResponse.sharedInstance handleAuthorizationResponseURL:callbackURL];


We came to this method through a custom scheme. We might need to evaluate if 'callbackURLScheme' could be used too.

Good point. nil only works if it's the only url scheme a customer has specified in their URL types. I'll add a way for a customer to supply this parameter as well.

@ysd24: Do you have a preferred way to supply this? I can either:

provide it via MAS -> MASModelService

rewrite the the enum to some sort of configuration object which the user can provide.

@ysd24 updated PR so users an provide the call back url scheme when using a web session

ysd24 · 2020-12-16T11:30:36Z

MASFoundation/Classes/models/MASBrowserBasedAuthentication.m

-            DLog(@"Browser cancel clicked");
-        }
-    });
+    MASBrowserBasedAuthenticationType type = [MASModelService browserBasedAuthenticationType];


We have to think about backward compatibility, in terms of an existing customer who uses the 'BrowserBasedLogin'

If a customer doesn't set a preferred browser type the old implementation (SFSafariViewController) will be used. If the implementation is correct existing customers should not be impacted when updating to a newer version of the SDK.

ysd24 · 2020-12-16T17:11:31Z

We have to think about backward compatibility, in terms of an existing customer who uses the 'BrowserBasedLogin' should not need to set the flag, instead the default behaviour has to be intact.

…e session browser based login

ysd24

** Looks all good to me.
But had a bit of a hitch with taking an input for a custom url scheme from the customer.
I am coming from the perspective of 'its a SDK/Library', we might don't want to ask for the custom url scheme of the app.
What i am trying to see here is, we open the web login template on the ASWebAuthSession and upon the completion it redirects to the custom url scheme, this kicks the app re-opened again and the app delegate, delegates the callback url to the AuthResponse class. Is it possible through ASWebSession ??

ysd24 · 2021-01-06T09:27:15Z

MASFoundation/Classes/_private_/models/MASWebSessionBrowserBasedAuthentication.h

+ * @param callbackURLScheme NSString containing the callback url scheme to use.
+ * @return Returns the newly initialized MASWebSessionBrowserBasedAuthentication.
+ */
+- (instancetype)initWithCallbackURLScheme:(NSString *)callbackURLScheme;


** Looks all good to me.
But had a bit of a hitch with taking an input for a custom url scheme from the customer.
I am coming from the perspective of 'its a SDK/Library', we might don't want to ask for the custom url scheme of the app.
What i am trying to see here is, we open the web login template on the ASWebAuthSession and upon the completion it redirects to the custom url scheme, this kicks the app re-opened again and the app delegate, delegates the callback url to the AuthResponse class. Is it possible through ASWebSession ??

I removed the need to provide the url scheme altogether for the WebSession browser authentication type. This will be extracted from the MSSO config.

…rowser type. Also improved interface when setting the type of browser used for swift.

BobbyWeber and others added 27 commits December 14, 2017 12:12

Merge pull request CAAPIM#122 from CAAPIM/Stable

7430418

Merge Stable into Master

Merge branch 'Stable'

553eb10

* Stable: Update CHANGELOG.md

Merge branch 'Stable'

c14b271

Merge branch 'Stable'

75d6c76

Merge branch 'Stable'

ef25850

Merge branch 'Stable'

90fb3f4

Merge branch 'Stable'

65706bf

Merge branch 'Stable'

7fc8754

iOS13 Changes for ASN.1 decoding null pointer bit string issue

9ab0730

Removing Mac Catalyst Support for Final build

e43509b

Removing Mac Catalyst Support for Final Build

f93934b

Fixing test targets for iOS 13

31c4231

Updated changelog for 1.9.20

8682e50

Merge pull request CAAPIM#224 from CAAPIM/iOS-13-Master

bc1d6b2

Updated changelog for 1.9.20

Merge branch 'develop' into merge-develop

374c7b3

# Conflicts: # CHANGELOG.md

Merge pull request CAAPIM#232 from CAAPIM/merge-develop

cecb20d

Merge develop

Merge pull request CAAPIM#250 from CAAPIM/develop

bdc0bad

MAS 2.1.00 release merge

Added the option for a user to configure what browser they want to us…

1e6d309

…e for browser based authentication

Fixed indentation

6423696

Remove unneeded edits to the project file

9428327

Remove workspace checks

ef20369

Remove more unneeded edits

a2374bc

Add some more whitespaces to adhere to coding guidelines

33158cf

Added pragma marks, and utility log statements

6a2da19

Change __block to __weak to prevent possible retain cycles

7ee1716

Missed 1 weakSelf

b492e32

zakirjt requested a review from ysd24 December 16, 2020 14:48

ysd24 reviewed Dec 16, 2020

View reviewed changes

Added option to provide the callack url scheme when choosing to use w…

7c48c43

…e session browser based login

ysd24 reviewed Jan 6, 2021

View reviewed changes

Removed the need to provide a url scheme when using the Web session b…

4e6029d

…rowser type. Also improved interface when setting the type of browser used for swift.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option for user to select browser type to use for browser based authentication #265

Add option for user to select browser type to use for browser based authentication #265

sandersaelmans commented Dec 8, 2020 •

edited

Loading

ysd24 left a comment

ysd24 Dec 16, 2020

sandersaelmans Dec 17, 2020 •

edited

Loading

sandersaelmans Dec 22, 2020

ysd24 Dec 16, 2020

sandersaelmans Dec 17, 2020

ysd24 commented Dec 16, 2020

ysd24 left a comment

ysd24 Jan 6, 2021

sandersaelmans Feb 1, 2021

Add option for user to select browser type to use for browser based authentication #265

Are you sure you want to change the base?

Add option for user to select browser type to use for browser based authentication #265

Conversation

sandersaelmans commented Dec 8, 2020 • edited Loading

Issue

Changes

Future Changes

ysd24 left a comment

Choose a reason for hiding this comment

ysd24 Dec 16, 2020

Choose a reason for hiding this comment

sandersaelmans Dec 17, 2020 • edited Loading

Choose a reason for hiding this comment

sandersaelmans Dec 22, 2020

Choose a reason for hiding this comment

ysd24 Dec 16, 2020

Choose a reason for hiding this comment

sandersaelmans Dec 17, 2020

Choose a reason for hiding this comment

ysd24 commented Dec 16, 2020

ysd24 left a comment

Choose a reason for hiding this comment

ysd24 Jan 6, 2021

Choose a reason for hiding this comment

sandersaelmans Feb 1, 2021

Choose a reason for hiding this comment

sandersaelmans commented Dec 8, 2020 •

edited

Loading

sandersaelmans Dec 17, 2020 •

edited

Loading