Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnionN::clone to check alignment of the cloned pointer #90

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

RustyYato
Copy link
Contributor

fixes #89

@RustyYato RustyYato changed the title Fix UnionN::clone to check alignemnt of the cloned pointer Fix UnionN::clone to check alignement of the cloned pointer Jan 15, 2025
@RustyYato RustyYato changed the title Fix UnionN::clone to check alignement of the cloned pointer Fix UnionN::clone to check alignment of the cloned pointer Jan 15, 2025
@RustyYato
Copy link
Contributor Author

Do you want me to fix the MIRI build? It looks like it's due to the unexpected CFGs check which where introduced since the last time you got a PR.

@CAD97
Copy link
Owner

CAD97 commented Jan 16, 2025

I can fix the cfg bits, thanks for the patch!

@CAD97 CAD97 merged commit 2f698df into CAD97:master Jan 16, 2025
4 of 5 checks passed
@RustyYato RustyYato deleted the ptr-union-clone-fix branch January 16, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone for UnionN is unsound with malicious P: ErasablePtr + Clone
2 participants