Skip to content

Commit

Permalink
Updated auth documentation, link login warning to doc (pinterest#407)
Browse files Browse the repository at this point in the history
  • Loading branch information
czgu authored Feb 1, 2021
1 parent f9546c8 commit 9535291
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
13 changes: 11 additions & 2 deletions components/UnauthPage/UnauthPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { SignupForm } from './SignupForm';
import { Box } from 'ui/Box/Box';
import { Message } from 'ui/Message/Message';
import { QuerybookLogo } from 'ui/QuerybookLogo/QuerybookLogo';
import { Link } from 'ui/Link/Link';
import './UnauthPage.scss';

export interface IUnauthPageProps {
Expand Down Expand Up @@ -60,15 +61,23 @@ export class UnauthPage extends React.Component<
<Message type="error">
<p>
NOTE: This signup/login flow is only for people who
wants to temporarily try out Querybook.
wants to <b>temporarily</b> try out Querybook.
</p>
<p>
The user name and password (as salted hash) information
is only stored in the Querybook Database and is not
passed anywhere.
</p>
<br />
<p>
Please use OAuth or other login methods for production.
Check out{' '}
<Link
to="https://www.querybook.org/docs/integrations/add_auth"
naturalLink
>
the authentication guide
</Link>{' '}
to learn how to set it up for your org.
</p>
</Message>
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/UserLoader/UserLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export const UserLoader: React.FunctionComponent = ({ children }) => {
has_login: boolean;
has_signup: boolean;
}>(`/user/login_method/`);
setShowSignup(hasLogin);
setShowUnauth(hasSignup);
setShowSignup(hasSignup);
setShowUnauth(hasLogin);
} catch (e2) {
setFetchError(e2);
}
Expand Down
1 change: 1 addition & 0 deletions ui/Link/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const StyledLink = styled('a')`
naturalLink &&
`
color: inherit;
text-decoration: underline;
`};
`;

Expand Down

0 comments on commit 9535291

Please sign in to comment.