-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 이메일 인증 기능 구현 #127
Conversation
Test Results111 tests 110 ✅ 13s ⏱️ Results for commit 313bd00. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
import com.cakk.external.service.MailService; | ||
|
||
@RequiredArgsConstructor | ||
@Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listener 부분도 @component를 메타 애노테이션으로 갖는 @eventlistener 같은거 만들어주실 수 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 만들어서 일괄 적용하겠습니다! 확실히 Component 어노테이션은 안 이쁘네요
@@ -0,0 +1,18 @@ | |||
package com.cakk.common.utils; | |||
|
|||
public class RandomUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성자 엑세스 레벨 관리하는건 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private으로 두었습니다.
#124
메일 전송 관련 기능을 구현하였습니다. 로컬에서 테스트가 안돼서 ec2 환경에서는 잘될지 테스트 해보려합니다. 코드와 로직만 보시면 될 것 같습니다.