-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 위치 기반 케이크 샵 조회 시, 클라이언트 요청 파라미터 추가 #166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #166 +/- ##
=============================================
- Coverage 85.62% 85.33% -0.29%
+ Complexity 308 306 -2
=============================================
Files 103 103
Lines 946 948 +2
Branches 36 36
=============================================
- Hits 810 809 -1
- Misses 116 118 +2
- Partials 20 21 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
final Double distance = request.distance(); | ||
final Point point = PointMapper.supplyPointBy(latitude, longitude); | ||
|
||
final List<CakeShopByLocationParam> result = cakeShopReader.searchShopByLocationBased(point); | ||
final List<CakeShopByLocationParam> result = cakeShopReader | ||
.searchShopByLocationBased(point, Objects.requireNonNullElse(distance, 1000.0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requireNonNullElse를 distance 변수 초기화 시 쓰는게 어떨까여?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰를 늦게 봤네요 ㅋㅋ 다음에 수정하겠습니다
@@ -612,7 +611,7 @@ void searchCakeShopsByKeywordWithConditions2() { | |||
assertEquals(ReturnCode.SUCCESS.getCode(), response.getReturnCode()); | |||
assertEquals(ReturnCode.SUCCESS.getMessage(), response.getReturnMessage()); | |||
|
|||
assertEquals(3, data.size()); | |||
assertThat(data.size()).isGreaterThanOrEqualTo(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상황에 따라 다르겠지만, 테스트 검증은 하드코딩이 좋다고 하네요.
#165