Fix: 위치 기반 케이크 샵 조회 시, 클라이언트 요청 파라미터 추가 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #166 +/- ##
=============================================
- Coverage 85.62% 85.33% -0.29%
+ Complexity 308 306 -2
=============================================
Files 103 103
Lines 946 948 +2
Branches 36 36
=============================================
- Hits 810 809 -1
- Misses 116 118 +2
- Partials 20 21 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lcomment
approved these changes
Jul 18, 2024
Comment on lines
+161
to
+165
| final Double distance = request.distance(); | ||
| final Point point = PointMapper.supplyPointBy(latitude, longitude); | ||
|
|
||
| final List<CakeShopByLocationParam> result = cakeShopReader.searchShopByLocationBased(point); | ||
| final List<CakeShopByLocationParam> result = cakeShopReader | ||
| .searchShopByLocationBased(point, Objects.requireNonNullElse(distance, 1000.0)); |
There was a problem hiding this comment.
requireNonNullElse를 distance 변수 초기화 시 쓰는게 어떨까여?
There was a problem hiding this comment.
리뷰를 늦게 봤네요 ㅋㅋ 다음에 수정하겠습니다
| @@ -612,7 +611,7 @@ void searchCakeShopsByKeywordWithConditions2() { | |||
| assertEquals(ReturnCode.SUCCESS.getCode(), response.getReturnCode()); | |||
| assertEquals(ReturnCode.SUCCESS.getMessage(), response.getReturnMessage()); | |||
|
|
|||
| assertEquals(3, data.size()); | |||
| assertThat(data.size()).isGreaterThanOrEqualTo(0); | |||
There was a problem hiding this comment.
상황에 따라 다르겠지만, 테스트 검증은 하드코딩이 좋다고 하네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#165