Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-41 | 케이크 샵 관련 기능 이관 #191

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-41

Description

케이크 샵 관련 기능을 이관하고, API 디자인을 리팩토링 했습니다.

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Aug 22, 2024
@lcomment lcomment requested a review from YongsHub August 22, 2024 05:31
@lcomment lcomment self-assigned this Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Test Results

196 tests   196 ✅  18s ⏱️
 34 suites    0 💤
 34 files      0 ❌

Results for commit 85a138a.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #191      +/-   ##
=============================================
+ Coverage      89.11%   90.50%   +1.39%     
- Complexity       326      331       +5     
=============================================
  Files            110      110              
  Lines            983      990       +7     
  Branches          37       37              
=============================================
+ Hits             876      896      +20     
+ Misses            88       79       -9     
+ Partials          19       15       -4     
Files Coverage Δ Complexity Δ
...m/cakk/api/dto/request/shop/UpdateShopRequest.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bb339...85a138a. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@lcomment lcomment merged commit a867773 into develop Aug 23, 2024
3 checks passed
@lcomment lcomment deleted the feature/CAKK-41 branch August 23, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants