Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-58 | 유저 관련 로직에 Facade 패턴 적용 #196

Closed
wants to merge 4 commits into from

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-58

Description

User 관련 로직에 Facade Pattern을 적용하고, 미사용 Writer를 제거하였습니다. Writer는 리팩토링 종류 후 Deprecated 될 예정인데, Reader에 대한 고민이 있습니다.

  1. Reader도 Facade로 네이밍 변경이 필요해 보입니다.
  2. Querydsl로 작성된 일부 쿼리를 도메인 모델 패턴로 리팩토링 하는 것도 좋아보입니다.

관련하여 코멘트 주세요.

etc

@lcomment lcomment added feature 새로운 기능 개발 refactor 비즈니스 변경 없는 수정 labels Aug 28, 2024
@lcomment lcomment requested a review from YongsHub August 28, 2024 13:22
@lcomment lcomment self-assigned this Aug 28, 2024
@lcomment lcomment closed this Aug 28, 2024
@lcomment lcomment deleted the refactor/CAKK-58 branch August 28, 2024 13:24
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #196      +/-   ##
=============================================
- Coverage      89.72%   88.57%   -1.16%     
+ Complexity       327      323       -4     
=============================================
  Files            110      110              
  Lines            983      980       -3     
  Branches          36       36              
=============================================
- Hits             882      868      -14     
- Misses            85       93       +8     
- Partials          16       19       +3     
Files Coverage Δ Complexity Δ
...in/java/com/cakk/api/service/user/SignService.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...in/java/com/cakk/api/service/user/UserService.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aef33c...38fce4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 개발 refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants