Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy | CAKK-61 | v.2.0.4 배포 #202

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Deploy | CAKK-61 | v.2.0.4 배포 #202

merged 5 commits into from
Aug 31, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

�CAKK-61

Description

  • DIP 위반 사례 해결

etc

* Feature | CAKK-58 | User Command 관련 Facade 구현

* Refactor | CAKK-58 | 미사용 Writer 삭제

* Refactor | CAKK-58 | Service 레이어에 Facade 패턴 적용

* Test | CAKK-58 | Facade 테스트 추상 클래스 구축 및 테스트 작성
* Chore | CAKK-58 | kt dsl 적용 및 kotlin 의존성 주입

* Rename .java to .kt

* Refactor | CAKK-58 | send 관련 코틀린 적용 및 추상화

* Refactor | CAKK-58 | 사업자 인증 관련 리팩토링

* Refactor | CAKK-58 | 이메일 인증 관련 리팩토링

* Refactor | CAKK-58 | 함수형 인터페이스로 수정

* Refactor | CAKK-58 | 파라미터 수정

* Refactor | CAKK-58 | 템플릿 콜백 패턴 적

* Refactor | CAKK-58 | 템플릿 콜백 패턴 적용
* Refactor | CAKK-59 | MessageExtractor 인터페이스 추상화

* Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거

* Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거

* Refactor | CAKK-59 | 메시지 extractor, template 추상화

* Refactor | CAKK-59 | 에러 메시지 리스너 구현

* Refactor | CAKK-59 | api 모듈 slack 의존성 제거

* Refactor | CAKK-59 | 메시지 관련 비즈니스 리팩토링

* Test | CAKK-59 | 메시지 전송 관련 테스트 수정

* Chore | CAKK-59 | jacoco exclude에 리스너 등록

* Refactor | CAKK-59 | email 관련 sender 네이밍 수정

* Refactor | CAKK-59 | 제네릭 범위 수정

* Test | CAKK-59 | Error 관련 리스너 테스트 작성
* Chore | CAKK-61 | mail 및 slack 의존성 추가

* Refactor | CAKK-61 | Dip 위반 문제 해결
@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Aug 31, 2024
@lcomment lcomment self-assigned this Aug 31, 2024
Copy link

Test Results

 40 files  + 5   40 suites  +5   24s ⏱️ +6s
215 tests +20  215 ✅ +20  0 💤 ±0  0 ❌ ±0 
216 runs  +21  216 ✅ +21  0 💤 ±0  0 ❌ ±0 

Results for commit e0f0e15. ± Comparison against base commit aa21b60.

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
- Coverage     93.57%   93.31%   -0.26%     
- Complexity      332      333       +1     
============================================
  Files           109      109              
  Lines           965      973       +8     
  Branches         34       34              
============================================
+ Hits            903      908       +5     
- Misses           46       47       +1     
- Partials         16       18       +2     
Files with missing lines Coverage Δ Complexity Δ
...ava/com/cakk/api/config/MessageTemplateConfig.java 100.00% <100.00%> (ø) 7.00 <4.00> (+3.00)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa21b60...e0f0e15. Read the comment docs.

@lcomment lcomment merged commit 1a81a66 into master Aug 31, 2024
3 checks passed
@lcomment lcomment added the deploy 배포 관련 작업 label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy 배포 관련 작업 refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant