Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-62 | external 모듈 kt 전환 #204

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented Sep 2, 2024

Issue Number

CAKK-62

Description

저번 리팩토링에서 kt으로 전환하지 않은 나머지 클래스를 kt로 전환했습니다.

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Sep 2, 2024
@lcomment lcomment self-assigned this Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Test Results

 40 files   40 suites   25s ⏱️
215 tests 215 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit 245fba9.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #204      +/-   ##
=============================================
- Coverage      92.11%   91.92%   -0.20%     
+ Complexity       329      328       -1     
=============================================
  Files            109      109              
  Lines            964      966       +2     
  Branches          34       34              
=============================================
  Hits             888      888              
- Misses            57       58       +1     
- Partials          19       20       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757f811...245fba9. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@lcomment lcomment merged commit 75ed636 into develop Sep 3, 2024
3 checks passed
@lcomment lcomment deleted the refactor/CAKK-62 branch September 3, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants