Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-65 | 공통모듈 kt 전환 #206

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented Sep 6, 2024

Issue Number

CAKK-65

Description

공통 모듈에 대하여 kt으로 전환했습니다.

Core Code

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Sep 6, 2024
@lcomment lcomment self-assigned this Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Test Results

 40 files   40 suites   23s ⏱️
215 tests 215 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit 74774d5.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #206      +/-   ##
=============================================
+ Coverage      92.11%   92.54%   +0.43%     
  Complexity       329      329              
=============================================
  Files            109      109              
  Lines            964      966       +2     
  Branches          34       34              
=============================================
+ Hits             888      894       +6     
+ Misses            57       53       -4     
  Partials          19       19              
Files with missing lines Coverage Δ Complexity Δ
.../src/main/java/com/cakk/api/mapper/ShopMapper.java 96.22% <100.00%> (+3.77%) 25.00 <1.00> (+2.00)
...java/com/cakk/api/provider/oauth/OidcProvider.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...com/cakk/api/provider/oauth/PublicKeyProvider.java 11.11% <ø> (ø) 1.00 <0.00> (ø)
...akk/api/service/user/EmailVerificationService.java 92.30% <100.00%> (ø) 3.00 <0.00> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ed636...74774d5. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lombok 제거 이유가 뭔가용?

@lcomment
Copy link
Collaborator Author

lcomment commented Sep 8, 2024

lombok 제거 이유가 뭔가용?

아시다시피, 코틀린은 네임드 파라미터를 제공하기에 빌더가 필요하지 않습니다. 이외에도 간편한 생성자 작성법 등 롬복이 딱히 필요가 없기에 롬복 의존성은 자바에서만 필요합니다. ApiResponse의 경우, api 모듈 등에서 너무 많이 사용하고 있어서, 차차 변환 예정이고, 그에 따라 의존성만 제한을 주기 위해 롬복 제고 및 getter를 하드코딩 했습니다

@lcomment lcomment merged commit 4c8ec2a into develop Sep 9, 2024
3 checks passed
@lcomment lcomment deleted the refactor/CAKK-65 branch September 9, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants