-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor | CAKK-65 | 공통모듈 kt 전환 #206
Conversation
Test Results 40 files 40 suites 23s ⏱️ Results for commit 74774d5. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #206 +/- ##
=============================================
+ Coverage 92.11% 92.54% +0.43%
Complexity 329 329
=============================================
Files 109 109
Lines 964 966 +2
Branches 34 34
=============================================
+ Hits 888 894 +6
+ Misses 57 53 -4
Partials 19 19
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lombok 제거 이유가 뭔가용?
아시다시피, 코틀린은 네임드 파라미터를 제공하기에 빌더가 필요하지 않습니다. 이외에도 간편한 생성자 작성법 등 롬복이 딱히 필요가 없기에 롬복 의존성은 자바에서만 필요합니다. ApiResponse의 경우, api 모듈 등에서 너무 많이 사용하고 있어서, 차차 변환 예정이고, 그에 따라 의존성만 제한을 주기 위해 롬복 제고 및 getter를 하드코딩 했습니다 |
CAKK-65
공통 모듈에 대하여 kt으로 전환했습니다.