Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy | CAKK-53 | v2.0.4 배포 #207

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Deploy | CAKK-53 | v2.0.4 배포 #207

merged 13 commits into from
Sep 9, 2024

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented Sep 9, 2024

Issue Number

CAKK-53

Description

  • kt 전환
  • Facade 도입

etc

lcomment and others added 13 commits August 29, 2024 11:52
* Feature | CAKK-58 | User Command 관련 Facade 구현

* Refactor | CAKK-58 | 미사용 Writer 삭제

* Refactor | CAKK-58 | Service 레이어에 Facade 패턴 적용

* Test | CAKK-58 | Facade 테스트 추상 클래스 구축 및 테스트 작성
* Chore | CAKK-58 | kt dsl 적용 및 kotlin 의존성 주입

* Rename .java to .kt

* Refactor | CAKK-58 | send 관련 코틀린 적용 및 추상화

* Refactor | CAKK-58 | 사업자 인증 관련 리팩토링

* Refactor | CAKK-58 | 이메일 인증 관련 리팩토링

* Refactor | CAKK-58 | 함수형 인터페이스로 수정

* Refactor | CAKK-58 | 파라미터 수정

* Refactor | CAKK-58 | 템플릿 콜백 패턴 적

* Refactor | CAKK-58 | 템플릿 콜백 패턴 적용
* Refactor | CAKK-59 | MessageExtractor 인터페이스 추상화

* Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거

* Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거

* Refactor | CAKK-59 | 메시지 extractor, template 추상화

* Refactor | CAKK-59 | 에러 메시지 리스너 구현

* Refactor | CAKK-59 | api 모듈 slack 의존성 제거

* Refactor | CAKK-59 | 메시지 관련 비즈니스 리팩토링

* Test | CAKK-59 | 메시지 전송 관련 테스트 수정

* Chore | CAKK-59 | jacoco exclude에 리스너 등록

* Refactor | CAKK-59 | email 관련 sender 네이밍 수정

* Refactor | CAKK-59 | 제네릭 범위 수정

* Test | CAKK-59 | Error 관련 리스너 테스트 작성
* Chore | CAKK-61 | mail 및 slack 의존성 추가

* Refactor | CAKK-61 | Dip 위반 문제 해결
Refactor | CAKK-57 | 케이크 도메인 로직 리팩토링
* Rename .java to .kt

* Refactor | CAKK-62 | kotlin으로 전환

* Test | CAKK-62 | 테스트 코드 수정
* Refactor | CAKK-63 | UserCommandFacade 네이밍 수정

* Refactor | CAKK-63 | Facade 패턴 적용

* Refactor | CAKK-63 | Writer 제거
* Rename .java to .kt

* Refactor | CAKK-65 | kt 전환

* Refactor | CAKK-65 | kt 전환에 따른 수정

* Refactor | CAKK-65 | lombok 제거
@lcomment lcomment added the deploy 배포 관련 작업 label Sep 9, 2024
@lcomment lcomment self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Test Results

 40 files  + 5   40 suites  +5   23s ⏱️ +4s
215 tests +20  215 ✅ +20  0 💤 ±0  0 ❌ ±0 
216 runs  +21  216 ✅ +21  0 💤 ±0  0 ❌ ±0 

Results for commit 4c8ec2a. ± Comparison against base commit 1a81a66.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
- Coverage     93.57%   92.33%   -1.24%     
+ Complexity      332      330       -2     
============================================
  Files           109      109              
  Lines           965      966       +1     
  Branches         34       34              
============================================
- Hits            903      892      -11     
- Misses           46       58      +12     
  Partials         16       16              
Files with missing lines Coverage Δ Complexity Δ
...ava/com/cakk/api/config/MessageTemplateConfig.java 100.00% <100.00%> (ø) 7.00 <4.00> (+3.00)
.../src/main/java/com/cakk/api/mapper/ShopMapper.java 96.22% <100.00%> (ø) 25.00 <1.00> (ø)
...java/com/cakk/api/provider/oauth/OidcProvider.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...com/cakk/api/provider/oauth/PublicKeyProvider.java 11.11% <ø> (ø) 1.00 <0.00> (ø)
...in/java/com/cakk/api/service/cake/CakeService.java 97.14% <100.00%> (-0.59%) 10.00 <1.00> (-2.00)
...in/java/com/cakk/api/service/shop/ShopService.java 98.59% <100.00%> (ø) 20.00 <0.00> (ø)
...akk/api/service/user/EmailVerificationService.java 92.30% <100.00%> (ø) 3.00 <0.00> (ø)
...in/java/com/cakk/api/service/user/SignService.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...in/java/com/cakk/api/service/user/UserService.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa21b60...4c8ec2a. Read the comment docs.

@lcomment lcomment merged commit 60a6bb3 into master Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy 배포 관련 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants