-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor | CAKK-84 | listener 및 테스트 kt 전환 #212
Conversation
Test Results 40 files 40 suites 29s ⏱️ Results for commit ac3b821. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #212 +/- ##
=============================================
- Coverage 92.14% 91.86% -0.28%
Complexity 329 329
=============================================
Files 109 98 -11
Lines 967 934 -33
Branches 34 33 -1
=============================================
- Hits 891 858 -33
- Misses 58 62 +4
+ Partials 18 14 -4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EventMapper에서 34 Line Test Cover도 한번 확인해주세요!
val latitude: Double?, | ||
val longitude: Double? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 nullable 제거 가능한가요?
@@ -36,6 +36,7 @@ class UserServiceTest extends ServiceTest { | |||
void findProfile1() { | |||
// given | |||
final User user = getUser(); | |||
System.out.println(user.getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제거해주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
CAKK-84
listener와 몇몇 테스트를 kt으로 전환했습니다.