Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-84 | listener 및 테스트 kt 전환 #212

Merged
merged 8 commits into from
Sep 21, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-84

Description

listener와 몇몇 테스트를 kt으로 전환했습니다.

etc

@lcomment lcomment added refactor 비즈니스 변경 없는 수정 test 테스트 작성 labels Sep 21, 2024
@lcomment lcomment self-assigned this Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

Test Results

 40 files   40 suites   29s ⏱️
212 tests 212 ✅ 0 💤 0 ❌
213 runs  213 ✅ 0 💤 0 ❌

Results for commit ac3b821.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...pi/dto/request/cake/CakeSearchByCategoryRequest.kt 80.00% 1 Missing ⚠️
...kk/api/dto/request/cake/CakeSearchByShopRequest.kt 80.00% 1 Missing ⚠️
...src/main/java/com/cakk/api/mapper/EventMapper.java 50.00% 1 Missing ⚠️

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #212      +/-   ##
=============================================
- Coverage      92.14%   91.86%   -0.28%     
  Complexity       329      329              
=============================================
  Files            109       98      -11     
  Lines            967      934      -33     
  Branches          34       33       -1     
=============================================
- Hits             891      858      -33     
- Misses            58       62       +4     
+ Partials          18       14       -4     
Files with missing lines Coverage Δ Complexity Δ
...ava/com/cakk/api/controller/cake/CakeController.kt 100.00% <100.00%> (ø) 11.00 <11.00> (?)
...a/com/cakk/api/controller/shop/ShopController.java 100.00% <ø> (ø) 16.00 <0.00> (ø)
...a/com/cakk/api/controller/user/SignController.java 100.00% <100.00%> (ø) 6.00 <2.00> (ø)
...com/cakk/api/dto/request/cake/CakeCreateRequest.kt 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...pi/dto/request/cake/CakeSearchByLocationRequest.kt 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...k/api/dto/request/cake/CakeSearchByViewsRequest.kt 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...com/cakk/api/dto/request/cake/CakeUpdateRequest.kt 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...m/cakk/api/dto/request/user/GenerateCodeRequest.kt 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...om/cakk/api/dto/request/user/VerifyEmailRequest.kt 100.00% <100.00%> (ø) 3.00 <3.00> (?)
.../src/main/java/com/cakk/api/mapper/CakeMapper.java 98.52% <100.00%> (+0.91%) 20.00 <6.00> (+6.00)
... and 6 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b054e51...ac3b821. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EventMapper에서 34 Line Test Cover도 한번 확인해주세요!

Comment on lines 11 to 12
val latitude: Double?,
val longitude: Double?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 nullable 제거 가능한가요?

@@ -36,6 +36,7 @@ class UserServiceTest extends ServiceTest {
void findProfile1() {
// given
final User user = getUser();
System.out.println(user.getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거해주세요!

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@lcomment lcomment merged commit cb99ec6 into develop Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정 test 테스트 작성
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants