Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-86 | 일부 파일 코틀린 전환 #214

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-86

Description

  • do
  • do

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Sep 23, 2024
@lcomment lcomment self-assigned this Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Test Results

 40 files   40 suites   29s ⏱️
211 tests 211 ✅ 0 💤 0 ❌
212 runs  212 ✅ 0 💤 0 ❌

Results for commit 0850c0c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 87.40157% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...main/java/com/cakk/api/provider/jwt/JwtProvider.kt 71.42% 15 Missing and 1 partial ⚠️

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #214      +/-   ##
=============================================
+ Coverage      92.14%   92.48%   +0.34%     
+ Complexity       329      328       -1     
=============================================
  Files            109       89      -20     
  Lines            967      985      +18     
  Branches          34       32       -2     
=============================================
+ Hits             891      911      +20     
- Misses            58       60       +2     
+ Partials          18       14       -4     
Files with missing lines Coverage Δ Complexity Δ
...ava/com/cakk/api/controller/cake/CakeController.kt 100.00% <ø> (ø) 11.00 <0.00> (?)
...om/cakk/api/controller/search/KeywordController.kt 100.00% <ø> (ø) 2.00 <0.00> (?)
...ava/com/cakk/api/controller/shop/ShopController.kt 100.00% <ø> (ø) 17.00 <0.00> (?)
...a/com/cakk/api/controller/user/MyPageController.kt 100.00% <100.00%> (ø) 6.00 <1.00> (?)
...ava/com/cakk/api/controller/user/SignController.kt 100.00% <100.00%> (ø) 7.00 <4.00> (?)
.../src/main/java/com/cakk/api/mapper/CakeMapper.java 98.48% <100.00%> (+0.86%) 20.00 <0.00> (+6.00)
...src/main/java/com/cakk/api/mapper/EventMapper.java 100.00% <ø> (+3.44%) 3.00 <0.00> (-3.00) ⬆️
...rc/main/java/com/cakk/api/mapper/SearchMapper.java 100.00% <ø> (ø) 7.00 <0.00> (+6.00)
.../src/main/java/com/cakk/api/mapper/ShopMapper.java 97.26% <100.00%> (+1.03%) 33.00 <0.00> (+8.00)
...pi/src/main/java/com/cakk/api/mapper/UserMapper.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fffe7...0850c0c. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test coverage만 확인해주시면 될 것 같습니다!

@lcomment
Copy link
Collaborator Author

test coverage만 확인해주시면 될 것 같습니다!

코틀린 전환하면서 JwtProvider 커버리지가 낮아진거 같은데, 이후에 보충하도록 하겠습니다 ! (당장의 목표 커버리지 70%은 넘기고 있어서요!)

@lcomment lcomment merged commit ab08b79 into develop Sep 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants