Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: TestWithDisplayName 어노테이션 구현 및 적용 #35

Merged
merged 4 commits into from
May 23, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

#34

Description

기존, 메서드명으로 테스트 케이스 네이밍을 했는데, @DisplayName으로 명시하기로 결정돼 코드를 간소화 하기 위해 @TestWithDisplayName 어노테이션을 구현하였습니다.

Core Code

@TestWithDisplayName("카테고리에 해당하는 케이크 목록을 조회한다")
void findCakeImagesByCursorAndCategory1() {
. . .

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label May 23, 2024
@lcomment lcomment requested a review from YongsHub May 23, 2024 02:19
@lcomment lcomment self-assigned this May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Test Results

16 tests  ±0   15 ✅ ±0   2s ⏱️ ±0s
 5 suites ±0    1 💤 ±0 
 5 files   ±0    0 ❌ ±0 

Results for commit 0248425. ± Comparison against base commit 5afd991.

This pull request removes 16 and adds 16 tests. Note that renamed tests count towards both.
com.cakk.api.ArchitectureTest ‑ Entity는 아무것도 의존하지 않는다.
com.cakk.api.ArchitectureTest ‑ Provider 클래스는 Service, Filter, Provider 클래스에만 의존해야 한다.
com.cakk.api.ArchitectureTest ‑ response 패키지 안에 있는 클래스들은 Response로 끝나야 한다.
com.cakk.api.integration.cake.CakeIntegrationTest ‑ 카테고리로_다음_페이지_케이크_이미지_조회에_성공한다()
com.cakk.api.integration.cake.CakeIntegrationTest ‑ 카테고리로_케이크_이미지_조회_시_데이터가_없으면_빈_배열을_반환한다()
com.cakk.api.integration.cake.CakeIntegrationTest ‑ 카테고리로_케이크_이미지_조회에_성공한다()
com.cakk.api.provider.JwtProviderTest ‑ User가 null인 경우, 토큰 생성에 실패한다.
com.cakk.api.provider.JwtProviderTest ‑ 액세스 토큰으로부터 인증 정보를 가져온다.
com.cakk.api.provider.JwtProviderTest ‑ 토큰 생성에 성공한다.
com.cakk.api.provider.JwtProviderTest ‑ 토큰으로부터 Claim 정보를 가져온다.
…
com.cakk.api.ArchitectureTest ‑ entityNotDependency()
com.cakk.api.ArchitectureTest ‑ providerDependency()
com.cakk.api.ArchitectureTest ‑ response()
com.cakk.api.integration.cake.CakeIntegrationTest ‑ searchByCategory1()
com.cakk.api.integration.cake.CakeIntegrationTest ‑ searchByCategory2()
com.cakk.api.integration.cake.CakeIntegrationTest ‑ searchByCategory3()
com.cakk.api.provider.JwtProviderTest ‑ generateToken1()
com.cakk.api.provider.JwtProviderTest ‑ generateToken2()
com.cakk.api.provider.JwtProviderTest ‑ getAuthentication()
com.cakk.api.provider.JwtProviderTest ‑ parseClaims()
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
com.cakk.api.ArchitectureTest ‑ Provider 클래스는 Service, Filter, Provider 클래스에만 의존해야 한다.
com.cakk.api.ArchitectureTest ‑ providerDependency()

♻️ This comment has been updated with latest results.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@lcomment lcomment merged commit 92b26cf into master May 23, 2024
2 checks passed
@lcomment lcomment deleted the refactor/#34 branch May 23, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants