Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 케이크 샵 상세 정보 조회 구현 #46

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented May 28, 2024

Issue Number

#41

Description

케이크 샵 상세 정보 조회 API를 개발했습니다. 특별한 로직 없이 조인하여 쿼리해왔습습니다.

select cs1_0.shop_id,
           cs1_0.shop_address,
           cs1_0.latitude,
           cs1_0.longitude,
            cso1_0.operation_day,
            cso1_0.start_time,
            cso1_0.end_time 
    from
        cake_shop cs1_0 
    join
        cake_shop_operation cso1_0 
            on cs1_0.shop_id=cso1_0.shop_id 
    where
        cs1_0.shop_id=1

Core Code

etc

@lcomment lcomment changed the title Feature: 케이크 샵 상세 정보 조회 쿼리 구현 Feature: 케이크 샵 상세 정보 조회 구현 May 28, 2024
Copy link

Test Results

39 tests   38 ✅  3s ⏱️
 7 suites   1 💤
 7 files     0 ❌

Results for commit 86cfdcc.

@lcomment lcomment requested a review from YongsHub May 28, 2024 06:57
@lcomment lcomment self-assigned this May 28, 2024
@lcomment lcomment added feature 새로운 기능 개발 test 테스트 작성 labels May 28, 2024
Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Comment on lines +67 to +71
public CakeShopInfoParam searchInfoById(Long cakeShopId) {
List<CakeShopInfoParam> results = queryFactory
.selectFrom(cakeShop)
.innerJoin(cakeShopOperation)
.on(cakeShop.eq(cakeShopOperation.cakeShop))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

올려주신 쿼리에서는 일반 join으로 나가던데 cakeShopOperation 모두 영속성 컨텍스트로 올라오냐요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql 기준으로 inner join과 join은 같은 join이고, 영속성 컨텍스트에 올라가는지 확인하진 않았으나, read 연산이 잘되었다면 read 후 올라가는걸로 알고 있습니다 !

@lcomment lcomment merged commit cf4e18e into master May 28, 2024
2 checks passed
@lcomment lcomment deleted the feature/#41 branch May 28, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 개발 test 테스트 작성
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants